Skip to content

gh-154189: Fix use-after-free in functools.partial_vectorcall#154508

Merged
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall
Jul 24, 2026
Merged

gh-154189: Fix use-after-free in functools.partial_vectorcall#154508
encukou merged 2 commits into
python:mainfrom
brijkapadia:partial-vectorcall

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@brijkapadia

Copy link
Copy Markdown
Contributor Author

@encukou, could you review this whenever you have time?
I'm asking since you reviewed #145362, which is similar to this pr.

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This checks out. Are you up for a bit of additional cleanup?

Comment thread Modules/_functoolsmodule.c Outdated
Comment thread Modules/_functoolsmodule.c Outdated

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@encukou encukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Jul 24, 2026
@encukou
encukou merged commit 1a742d4 into python:main Jul 24, 2026
62 of 63 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @brijkapadia for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @brijkapadia and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1a742d403243ac9915ffcc54e29516e58c44dc42 3.14

@bedevere-app

bedevere-app Bot commented Jul 24, 2026

Copy link
Copy Markdown

GH-154652 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 24, 2026
@brijkapadia
brijkapadia deleted the partial-vectorcall branch July 24, 2026 21:42
@brijkapadia

Copy link
Copy Markdown
Contributor Author

I don't think PR needs to be backported to 3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.14 bugs and security fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants